1119302 - Implement nsIContentPolicy.shouldProcess for plugin resource loads

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Benjamin Smedberg]

Plugin resource loads currently don't use nsIContentPolicy.shouldProcess, which means that we don't have MIME type data for them. This patch fixes that and is necessary for the experiment in bug 1108668.

Comment 1

[Benjamin Smedberg]

Attachment: Reviewboard request

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8546021 [details]
Reviewboard request

r+, but please see the reviewboard comments.  I wish it actually set the r+ state here instead of putting me through the extra work... filed bug 1119416.

Comment 3

[Benjamin Smedberg]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c40a9e043ce

Comment 4

[Benjamin Smedberg]

Comment on attachment 8546021 [details]
Reviewboard request

Approval Request Comment
[Feature/regressing bug #]: API needed for the experiment in bug 1108668
[User impact if declined]: Can't run the experiment
[Describe test coverage new/current, TBPL]: Manually verified with the experiment code
[Risks and why]: There is a risk that nsIContentPolicy implementations will see new notifications that they didn't expect and will somehow fail. I judge this risk as fairly low, and is mainly a risk with addons.
[String/UUID change made/needed]: None

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for failures in test_streamNotify.html:
https://treeherder.mozilla.org/logviewer.html#?job_id=5277932&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=5278924&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/157873c02e6d

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This also failed with this patch:
https://treeherder.mozilla.org/logviewer.html#?job_id=5280947&repo=mozilla-inbound

Comment 7

[Benjamin Smedberg]

https://hg.mozilla.org/integration/fx-team/rev/621fadc8702b I had to move the code later in the method so that error returns triggered notifications properly.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/621fadc8702b

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8546021 [details]
Reviewboard request

[Triage Comment]
After the merge.

Comment 10

[Benjamin Smedberg]

https://hg.mozilla.org/releases/mozilla-beta/rev/c447c4b139a9 (this made 37 before the merge)